fix: resolve all test failures and type errors across api and shared packages#36
Open
stooit wants to merge 1 commit into
Open
fix: resolve all test failures and type errors across api and shared packages#36stooit wants to merge 1 commit into
stooit wants to merge 1 commit into
Conversation
…packages - Fix auth middleware case-sensitivity bug (compare HTTP methods in uppercase) - Add missing badRequest import in users route handler - Fix field name inconsistency in User type (name -> username) - Implement paginate utility function with proper page slicing - Add bun-types to tsconfig for process.env typing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
"post") but Hono passes uppercase ("POST"), causing public routes to incorrectly return 401badRequestimport and fixed field name fromusernameto match the User type definitionUsertype field name (name→username) to match what both tests and route handlers expectpaginate<T>()function with proper 1-indexed page slicing, returning{ data, page, pageSize, total, totalPages }bun-typesto resolveprocess.envtyping error in auth middlewareVerification
All 22 tests pass across 4 test files with 37 assertions. Zero TypeScript type errors (
tsc --noEmitclean).Assumptions
Usertype's field should beusername(notname) since both tests and route handlers use that name