fix: resolve all test failures and type errors across api and shared packages#35
Open
stooit wants to merge 1 commit into
Open
fix: resolve all test failures and type errors across api and shared packages#35stooit wants to merge 1 commit into
stooit wants to merge 1 commit into
Conversation
…packages - Fix auth middleware case-sensitivity bug (POST method comparison) - Fix User type field name inconsistency (userName -> username) - Implement pagination utility (paginate function) - Add missing badRequest helper import in users route - Add bun.d.ts ambient declarations for bun:test and process
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
publicMethodscontained lowercase"post"but HTTP methods arrive as uppercase"POST", causing authenticated routes to reject valid public requestsuserNamefield tousernamein theUsertype to match what route handlers and tests expectpaginate<T>()function (was throwing "not implemented") with proper page slicing, bounds handling, and metadatabadRequesthelper import and replacedprocess.envwith Bun-compatible env accessbun.d.tsambient declarations forbun:testmodule andprocessglobal sotsc --noEmitpasses without modifying test filesVerification
All 22 tests pass (
bun test) and zero TypeScript errors (npx tsc --noEmit).Assumptions
Usertype's field was intentionally namedusername(matching tests and route handlers) — theuserNamevariant was the bugbadRequesthelper didn't exist; created a minimal one returningc.json({ error: message }, 400)process.envis available at runtime but needs ambient declarations fortsc