fix: resolve all test failures and type errors across api and shared packages#34
Open
stooit wants to merge 1 commit into
Open
fix: resolve all test failures and type errors across api and shared packages#34stooit wants to merge 1 commit into
stooit wants to merge 1 commit into
Conversation
…packages - Fix auth middleware case-sensitivity bug (method comparison now matches uppercase HTTP methods) - Replace process.env with Bun.env in auth middleware to fix TS2580 - Import badRequest helper in users route handler - Rename User type field from userName to username for consistency with tests - Implement paginate utility function in shared package - Add skipLibCheck to tsconfig for bun type compatibility
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
POST), causing authenticated routes to return 401process.envwithBun.envto eliminate TS2580 type errorbadRequestimport that caused runtime failuresuserNamefield tousernameinUsertype to match API contract expected by testspaginate<T>()function (was a stub throwing "not implemented")skipLibCheckfor Bun type compatibilityVerification
All 22 tests pass (
bun test) andnpx tsc --noEmitreports zero errors.Assumptions
Usertype field should beusername(lowercase, no camelCase) based on test expectationsBun.envis the appropriate replacement forprocess.envin this Bun-based project