fix: resolve all test failures and type errors across api and shared packages#33
Open
stooit wants to merge 1 commit into
Open
fix: resolve all test failures and type errors across api and shared packages#33stooit wants to merge 1 commit into
stooit wants to merge 1 commit into
Conversation
…packages - Fix auth middleware case-sensitivity bug (compare HTTP methods case-insensitively) - Replace process.env with Bun.env in auth middleware - Add missing badRequest import in users route handler - Rename userName to username in shared User type to match API contract - Implement paginate utility function with proper page slicing and bounds handling - Add skipLibCheck to tsconfig for cleaner type checking
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
POST, causing public routes to incorrectly return 401. Also replacedprocess.envwithBun.env.badRequestimport that caused runtime ReferenceError.userNamefield tousernamein theUsertype to match the API contract expected by tests.paginate()function with proper page slicing, bounds handling, and total page calculation.skipLibCheck: truefor cleaner type checking.Verification
All 22 tests pass across 4 test files, and
tsc --noEmitreports zero errors.Assumptions
usernamefield name is the correct API contract (tests send/expectusername, notuserName).Bun.envis the correct environment variable access pattern for this Bun-based project.