fix: resolve all test failures and type errors across api and shared packages#30
Open
stooit wants to merge 1 commit into
Open
fix: resolve all test failures and type errors across api and shared packages#30stooit wants to merge 1 commit into
stooit wants to merge 1 commit into
Conversation
…packages - Fix auth middleware case-sensitivity bug (HTTP methods must be uppercase) - Fix User type field name: userName -> username to match test expectations - Add missing badRequest helper and fix field references in users route - Implement pagination utility (paginate function) in shared package - Add process type declaration in auth.ts to resolve TS2580
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
publicMethodswere lowercase ("post") but compared against uppercase values from the request — POST/PUT/DELETE requests were incorrectly returning 401userNamefield tousernamein theUsertype to match what route handlers and tests expectbadRequesthelper function and fixed field name references to align with the correctedUsertypepaginate()function inpackages/shared/src/utils/pagination.tsto satisfy the existing test expectationsprocesstype declaration in auth middleware to eliminate TS2580 errorVerification
bun test)npx tsc --noEmit— remaining errors are only in test files due to missing@types/bun)Assumptions
tscerrors are in test files (bun:testmodule andprocessglobal) which are environment-specific and cannot be fixed without adding@types/bunas a dependencyAPI_TOKENenvironment variable name was preserved as-is from the original code