fix: resolve all failing tests and type errors#29
Open
stooit wants to merge 1 commit into
Open
Conversation
- Fix auth middleware case-sensitivity bug (POST method matching) - Rename User type field userName -> username for consistency - Implement pagination utility (paginate function) - Add badRequest import and fix field references in users route - Add env.d.ts for process type declaration
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
"post"didn't match the uppercase"POST"method from Hono, causing authenticated POST requests to return 401userName→usernamein theUsertype to match usage across the codebasepaginate()function that was previously a stub throwing "not implemented"badRequestimport and updated field references to useusernameenv.d.tswithprocessglobal declaration to resolve TS2580Verification
All 22 tests pass (
bun test) andtsc --noEmitreports zero errors.Assumptions
Usertype field should beusername(notuserName) based on test expectationspaginate()utility returns{ data, total, page, pageSize, totalPages }based on the test contractbadRequestis a local helper returning a 400 JSON response (created inline since no existing utility was found)