fix: resolve 5 cross-package bugs causing test failures#24
Open
stooit wants to merge 1 commit into
Open
Conversation
- Fix renamed hook import (useDebounce) in apps/web/src/lib/api.ts - Add jsdom test environment config for UI package tests - Pass aria-label prop through Button component for accessibility - Use day-first format without leading zero in date formatter - Fix stale closure in DataTable sort handler with functional state update
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes all failing tests across the monorepo by resolving 5 cross-package bugs:
apps/web/src/lib/api.tsimporteduseThrottlewhich was renamed touseDebounceinpackages/utils. Fixed the import and re-export alias (useSearchDebounce).[test] environment = "jsdom"topackages/ui/bunfig.toml.Buttoncomponent now passes througharia-labelprop for icon-only buttons.dd/MM/yyyytod/MM/yyyy(day without leading zero).sortDirectionvalue. Fixed with functional state update pattern.Verification
All 13 tests pass (
bun test). No source-file type errors (npx tsc --noEmit— onlybun:testmodule errors in test files, which are expected without bun type declarations installed).Assumptions
bun:testtype errors are pre-existing and not in scope (they only affect test files which we don't modify).