fix: resolve cross-package test failures in TypeScript monorepo#23
Open
stooit wants to merge 1 commit into
Open
fix: resolve cross-package test failures in TypeScript monorepo#23stooit wants to merge 1 commit into
stooit wants to merge 1 commit into
Conversation
- Fix renamed hook import: useThrottle → useDebounce in api.ts, re-export as useSearchDebounce - Add happy-dom environment to root and ui bunfig.toml for DOM test support - Fix Button component to pass through aria-label prop for accessibility - Fix DataTable stale closure bug in sort handler - Fix date formatting to use single-digit day (d/MM/yyyy format)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
useThrottle→useDebounce) inapps/web/src/lib/api.tsand re-exported asuseSearchDebouncehappy-domenvironment configuration to root andpackages/uibunfig.toml for DOM test supportaria-labelprop for accessibility complianced/MM/yyyy)Test Results
All 13 tests pass across 5 files. TypeScript type check passes (only expected
bun:testmodule resolution warnings remain in test files).Assumptions
bun:testtype errors are expected/acceptable since the project uses bun's test runner without@types/buninstalledbun testworks from both root and package directories