fix: resolve all failing tests across monorepo packages#22
Open
stooit wants to merge 1 commit into
Open
Conversation
- Fix useSearchDebounce/useThrottle export by re-exporting useDebounce under expected names (apps/web) - Add aria-label prop support to Button component (packages/ui) - Fix stale closure bug in DataTable sort handler using functional state update (packages/ui) - Fix date format string to use non-zero-padded day (packages/utils) - Configure happy-dom test environment via bunfig.toml preload (packages/ui)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
useSearchDebounce/useThrottleexport mismatch by re-exportinguseDebounceunder the expected consumer names inapps/web/src/lib/api.tsaria-labelprop passthrough to theButtoncomponent for icon-only button accessibilityDataTablesort handler by using functional state update (setSortDir(prev => ...))packages/utils/src/format/date.tsto use non-zero-padded day (d/MM/yyyy)packages/uitests viabunfig.tomlpreloadVerification
All 13 tests pass (
bun test) andtsc --noEmitreports no source-file type errors.Assumptions
bun:testmodule resolution warnings in test files are expected (bun provides these at runtime) and not real errorsuseDebouncehook inpackages/utilsis the correct implementation backing bothuseSearchDebounceanduseThrottleconsumer references