fix: resolve all cross-package test failures and type errors#19
Open
stooit wants to merge 1 commit into
Open
Conversation
- Add useSearchDebounce and useThrottle exports from packages/utils - Fix Button component to forward aria-label prop for accessibility - Fix DataTable stale closure bug using functional state update - Fix date formatting to use day without leading zero (d/MM/yyyy) - Configure happy-dom test environment in root bunfig.toml - Add bun-types to tsconfig for bun:test module resolution
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes all failing tests and TypeScript errors in this multi-package monorepo. The bugs spanned multiple packages with cross-cutting dependencies.
Changes
useSearchDebounceanduseThrottleas re-exports ofuseDebouncehook (the hook was renamed but consumers still referenced old names)aria-labelprop to the underlying<button>element for accessibilitysetSortDirection(prev => ...))d/MM/yyyy→ "1/03/2024")bun-typesto compiler types forbun:testmodule resolutionVerification
bun test→ 13 pass, 0 failnpx tsc --noEmit→ 0 errorsAssumptions
useSearchDebounceanduseThrottleare aliases for the same underlyinguseDebouncehookd/MM/yyyy(single-digit day, zero-padded month, 4-digit year)