fix: resolve 5 cross-package bugs causing test failures#18
Open
stooit wants to merge 1 commit into
Open
Conversation
- Fix renamed hook import: useThrottle → useDebounce in apps/web/src/lib/api.ts and re-export as useSearchDebounce from packages/utils - Add DOM test environment config in bunfig.toml for UI package tests - Add aria-label to icon-only Button component for accessibility - Fix date formatting to use non-zero-padded day (d/MM/yyyy) - Fix stale closure in DataTable sort handler using functional state update
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes all failing tests across the monorepo (13/13 now passing) by addressing 5 cross-package bugs:
useThrottle→useDebounceinapps/web/src/lib/api.ts, and re-exported asuseSearchDebouncefrompackages/utils[test] environmentconfig inbunfig.tomlso UI component tests have access todocumentaria-labelto icon-only<Button>for screen reader supportdd/MM/yyyytod/MM/yyyyto produce non-zero-padded dayAssumptions
bun:testTypeScript errors in test files are expected (no@types/buninstalled) and not in scope