platforms/qcm6490-idp: Fix emmc partitions options#136
Merged
Dmitry Baryshkov (lumag) merged 1 commit intoJul 2, 2026
Merged
Conversation
Beny-Compteq
requested review from
Dmitry Baryshkov (lumag),
Nicolas Dechesne (ndechesne) and
Viswanath Kraleti (vkraleti)
as code owners
Dmitry Baryshkov (lumag)
requested changes
Jul 2, 2026
Dmitry Baryshkov (lumag)
left a comment
Dmitry Baryshkov (lumag)
left a comment
Contributor
There was a problem hiding this comment.
See Git log to get examples of the commit message and commit subjects.
Beny-Compteq
force-pushed
the
fix_QCM6490-idp_emmc
branch
from
1be7e6a to
4885ba0
Compare
Beny-Compteq
changed the title
Contributor
Author
|
Better? |
Dmitry Baryshkov (lumag)
approved these changes
Jul 2, 2026
Dmitry Baryshkov (lumag)
requested changes
Jul 2, 2026
Dmitry Baryshkov (lumag)
left a comment
Dmitry Baryshkov (lumag)
left a comment
Contributor
There was a problem hiding this comment.
This fails the checksum test. Could you please check and fix it?
auto-merge was automatically disabled
July 2, 2026 12:26
Head branch was pushed to by a user without write access
Contributor
Author
|
Ah, sorry, I forgot to update. |
Contributor
Your second commit missed SoB. But while you are at it instead of adding SoB please squash both commits together. |
Fix wrong options copied from ufs in partitions.conf. Update disk type, write-protect-boundary and sector size. Signed-off-by: Beny-Compteq <daniel.benes@compteq.io>
Beny-Compteq
force-pushed
the
fix_QCM6490-idp_emmc
branch
from
56306cc to
b0b4a58
Compare
Contributor
Author
|
True, squashed. Sorry for the problems. |
Contributor
No worries, thanks for fixing it. |
Dmitry Baryshkov (lumag)
approved these changes
Jul 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix wrong options copied from ufs in partitions.conf.
Update disk type, write-protect-boundary and sector size.
Fix #131