ci/ci: Install ptest packages in all images#1900
ci/ci: Install ptest packages in all images#1900quaresmajose wants to merge 1 commit intoqualcomm-linux:masterfrom
Conversation
quaresmajose
requested review from
lumag,
mwasilew,
ndechesne,
ricardosalveti and
sbanerjee-quic
as code owners
quaresmajose
force-pushed
the
ptest
branch
2 times, most recently
from
1666dab to
eae42e9
Compare
|
ptests won't work with sota, and it is even removed from distro features. |
I forgot about that, I'll remove it from sota. |
Test run workflowTest jobs for commit eae42e9
All jobs summary
|
Test Results 27 files 27 suites 1h 41m 54s ⏱️ For more details on these failures, see this check. Results for commit 8456571. ♻️ This comment has been updated with latest results. |
Test run workflowTest jobs for commit 8456571
All jobs summary
|
|
I'm not sure we should add ptests by default in every image, maybe in only one variant? What is the image size implication here? |
|
As I said in #1903:
|
I'll measure that and add it to the commit. |
So how do you think we should go about installing the tests on the target? |
Here are the results for Before this PR: After this PR: |
This is a massive difference, we should discuss this more before pushing any changes here. |
|
Yes, I agree. |
Adding "ptest-pkgs" to IMAGE_FEATURES causes all -ptest packages to be additionally installed. To exercise the installed unit testing, we simply run ptest-runner. Ptests won't work with sota, and it is even removed from distro features. So it doesn't make sense to enable it in this case. Here are the results for `ci/qcom-armv8a.yml:ci/qcom-distro.yml` Before this PR: ``` 31G build/tmp/deploy/images/qcom-armv8a 1.6G qcom-container-orchestration-image-qcom-armv8a.rootfs.ext4.gz 0.7G qcom-multimedia-image-qcom-armv8a.rootfs.ext4.gz 1.4G qcom-multimedia-proprietary-image-qcom-armv8a.rootfs.ext4.gz ``` After this PR: ``` 48G build/tmp/deploy/images/qcom-armv8a 2.4G qcom-container-orchestration-image-qcom-armv8a.rootfs.ext4.gz 1.5G qcom-multimedia-image-qcom-armv8a.rootfs.ext4.gz 2.1G qcom-multimedia-proprietary-image-qcom-armv8a.rootfs.ext4.gz ``` Signed-off-by: Jose Quaresma <jose.quaresma@oss.qualcomm.com>
3 participants
Adding "ptest-pkgs" to IMAGE_FEATURES causes all -ptest packages
to be additionally installed.
To exercise the installed unit testing, we simply run ptest-runner.