ci: run the shared leak scan on every PR - #84
Merged
Merged
Conversation
Thin, SHA-pinned caller for infra-public's _reusable.leak-scan.yml. Scans the PR diff and the PR title/body for private infrastructure identifiers and fails closed. Enforcing from the start: a finding fails the check. Refs infra#2997 Claude-Session: https://claude.ai/code/session_01Ht7JaVzv2aacJ9r6Srso9r
WalkthroughAdds a new GitHub Actions workflow that invokes a shared, reusable leak-scan from the quadseven/infra-public repository to scan every pull request's diff, title, and body for accidental private infrastructure identifiers (hostnames, private IPs, device IDs, local paths, private repo refs). The scan runs on opened/synchronize/reopened/edited PR events, fails closed (a non-runnable scan is a failed check), and supports reviewed exceptions via a Review effort: quick (~5 min) Changed files (1)
Shape of the changegraph TD
subgraph ".github"
N0["check.leak-scan.yml"]
end
Last walked at |
Owner
Author
|
Codex adversarial review (pre-open), one finding, declined with evidence:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
This repo is public, and nothing checks a PR for private infrastructure identifiers before it merges. What leaks here is not secret-shaped (hostnames, private-range IPs, local user paths, refs to private repos), so secret scanning never sees it. A shared, fail-closed leak scan already exists in quadseven/infra-public; this adds the thin caller. Upstream tracking: infra#2997.
Summary
.github/workflows/check.leak-scan.yml: calls_reusable.leak-scan.ymlpinned to a full commit SHA, onpull_request(opened, synchronize, reopened, edited)allowed-repo-refslists only public repos this one cites routinely, plus the upstream tracker conventionAcceptance criteria
Out of scope
Size: S
Codex adversarial review: one finding (pull-requests permission), declined with evidence in a PR comment.
Part of #83
https://claude.ai/code/session_01Ht7JaVzv2aacJ9r6Srso9r