ci(leak-scan): turn on the shared deny-list layer - #116
Merged
Merged
Conversation
Pass the shared SSM deny-list parameter and the LEAK_SCAN_ROLE_ARN secret to the reusable, grant id-token: write for the OIDC read, and bump the reusable pin to infra-public main (includes infra-public#106, which reads the list one term per line and redacts hits). Mode unchanged. Part of #83 Claude-Session: https://claude.ai/code/session_01Ht7JaVzv2aacJ9r6Srso9r
WalkthroughThis PR upgrades the leak-scan workflow to pull a curated, externally-managed deny-list of sensitive terms (people, products, projects) from a secured SSM parameter at runtime via a restricted AWS role assumed through OIDC, rather than relying solely on the referenced reusable workflow's built-in generic-pattern detection; it grants id-token write permissions, pins a new reusable-workflow SHA, and wires up the deny-list SSM parameter path plus AWS role secret so forks run closed (no secrets) while trusted PRs gain redacted-hit coverage. Review effort: quick (~5 min) Changed files (1)
Shape of the changegraph TD
subgraph ".github"
N0["check.leak-scan.yml"]
end
Last walked at |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
This repo's leak scan runs the shared reusable with generic shapes only. Shapes cannot match a person, product or project name; those terms live in a shared SSM deny-list that is read at run time and never committed anywhere. The list and its read-only role now exist (infra#2997), and the shared scanner fix that reads the list one term per line and redacts every deny-list hit in the log (infra-public#106) is merged. This turns that layer on.
Summary
deny-list-ssm-param: /infra/leak-scan/deny-list, grantsid-token: writeon the job, and passesaws-role-arn: ${{ secrets.LEAK_SCAN_ROLE_ARN }}. The role can read that one parameter and nothing else, and trusts onlypull_requestruns.uses:pin moves to the current infra-public main commit (2737550), which includes infra-public#106.Acceptance criteria
Out of scope
Size: XS
Part of #83
https://claude.ai/code/session_01Ht7JaVzv2aacJ9r6Srso9r