Closed
Conversation
copybara-service
bot
force-pushed
the
test_899746853
branch
2 times, most recently
from
732755e to
1fba423
Compare
copybara-service
bot
force-pushed
the
test_899746853
branch
from
1fba423 to
cdd8ebd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Delete unreachable COND clause
In the (EQL 'BOOLEAN) method, the first two COND clauses each call a function which asserts its argument to be of type STRING. Therefore if those functions both return normally, VALUE can not possibly be EQ to T.
Except that given argument T in unsafe code, the predicates bypass their type checks, causing EQUALP and MEMBER to return NIL, EQ to return T, and causing divergence vs. safe code.