Skip to content

Add Seeded Samplers #537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jnsiemer merged 5 commits into from
Oct 19, 2026
+11,046 −4,309
Merged

Add Seeded Samplers #537

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6f9e0b6
Add optional seeding for base samplers
jnsiemer Oct 9, 2026
f680b5c
Further optionally seeded functions
jnsiemer Oct 9, 2026
3b2b2d3
Add seeded + unseeded public functions via macro
jnsiemer Oct 9, 2026
f098b35
Revise tests of (un)seeded samplers
jnsiemer Oct 19, 2026
420a891
Address comments from review
jnsiemer Oct 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
name = "qfall-math"
version = "0.2.0"
edition = "2024"
rust-version = "1.87" # due to wit_bindgen dependency
rust-version = "1.86"
description = "Mathematical foundations for rapid prototyping of lattice-based cryptography"
readme = "README.md"
homepage = "https://qfall.github.io"
Expand All @@ -26,7 +26,7 @@ thiserror = "2"
lazy_static = "1"
probability = "0.20"
derive_more = { version = "2.1", features = ["display"] }
flint3-sys = { version="3.6.0", features=["gmp-mpfr-sys"]}
flint3-sys = { version="3.6.1", features=["gmp-mpfr-sys"]}

[profile.bench]
debug = true
Expand Down
11 changes: 8 additions & 3 deletions benches/sample_z.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,9 +63,14 @@ pub fn bench_sample_z(c: &mut Criterion) {
];

for s in gaussian_widths {
let mut dgis =
DiscreteGaussianIntegerSampler::init(center, s, 6.0, LookupTableSetting::Precompute)
.unwrap();
let mut dgis = DiscreteGaussianIntegerSampler::init(
center,
s,
6.0,
LookupTableSetting::Precompute,
None,
)
.unwrap();

c.bench_function("DiscreteGauss RejectionSampling", |b| {
b.iter(|| dgis.sample_z())
Expand Down
Loading
Loading