feat(config): expose deleted_threshold and vacuum_min_vector_number - #163
Merged
Conversation
The upload config could set every optimizer knob except the two that control the vacuum optimizer, so a collection built by `bfb upload` could not be made to heal deletions promptly: Qdrant's defaults (deleted_threshold 0.2, vacuum_min_vector_number 1000) let a fifth of a segment rot before a rebuild. Any benchmark that deletes points needs both -- the healing experiment in BENCHMARK_ROADMAP.md L3, and the deferred-points search case. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
generall
approved these changes
Aug 10, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Adds support for two additional Qdrant optimizer tuning parameters in the upload YAML config so collection creation can pass them through to OptimizersConfigDiff.
Changes:
- Extend
OptimizersConfigwith optionaldeleted_thresholdandvacuum_min_vector_number. - Pass the new optimizer fields through when building
OptimizersConfigDiffBuilderfrom config. - Update the hand-written schema reference and the “reference covers every field” test fixture to include the new keys.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/config/schema.rs | Documents the new optimizer fields in the schema reference and includes them in the reference-example test fixture. |
| src/config/collection.rs | Adds the two new optional optimizer fields to the config struct. |
| src/collection/from_config.rs | Wires the new config fields through to Qdrant’s OptimizersConfigDiffBuilder. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds two optional fields to
collection.optimizersin the upload config, passed through to Qdrant'sOptimizersConfigDiff:deleted_thresholdf640.2vacuum_min_vector_numberu641000All Submissions:
devbranch. Did you create your branch fromdev?