fix: reject malformed email addresses at signup#544
Open
xpoes123 wants to merge 1 commit into
Open
Conversation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The signup route stored any string as an email address without validating its format. This adds a lightweight format check so obviously malformed addresses are rejected before they reach the database.
Problem
In
routes/auth/signup.js,req.body.emailwas passed directly tocreateUserwith no validation. A malformed email written to the database would cause silent failures downstream — password reset and email verification would silently no-op because the address is unparseable by the mail transport.Changes
validateEmail(email)toserver/authentication.js: a permissiveuser@domain.tldregex check (/^[^\s@]+@[^\s@]+\.[^\s@]+$/) that returnsfalseon obvious format errors.routes/auth/signup.js, applies the check beforesaltAndHashPasswordandcreateUser. The guard fires only when an email is provided — absent or empty-string emails pass through unchanged, so accounts that sign up without an email are unaffected.Risk & testing
No existing signup flow is broken: the validation is conditional on a non-empty email value. The regex is intentionally permissive to avoid false rejections of valid but unusual addresses. Mirrors the existing
validateUsernamepattern in the same file.node --checkpasses.