fix: record votekick rate-limit timestamp only after all guards pass#540
Open
xpoes123 wants to merge 1 commit into
Open
fix: record votekick rate-limit timestamp only after all guards pass#540xpoes123 wants to merge 1 commit into
xpoes123 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
votekickInit, the 90-second rate-limit timestamp was recorded before the duplicate-votekick and eligibility checks, so a rejected initiation still consumed the initiator's full cooldown window.Problem
In
server/multiplayer/ServerMultiplayerRoomMixin.js,this.lastVotekickTime[userId]was assigned immediately after the rate-limit guard — before the loop that checks whether a votekick against the target already exists. If that loop returned early (duplicate or ineligible target), the timestamp was already written, locking the initiator out for 90 seconds even though no votekick was created.Changes
this.lastVotekickTime[userId] = currentTimeto just before thenew Votekick(...)call, after all early-return guards have passed.Risk & testing
Single-line relocation; the rate-limit guard logic and the 90-second threshold are unchanged. The cooldown now only starts when a votekick is genuinely initiated, which matches the intended behavior.
semistandardandnode --checkpass.