ux: soften .text-highlight background in night mode#539
Open
xpoes123 wants to merge 1 commit into
Open
Conversation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
xpoes123
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The solid bright-yellow
.text-highlightbackground was visually jarring in night mode, creating a harsh contrast against the dark surface. This PR adds a night-mode override that uses a translucent amber so highlighted query terms remain clearly visible without overwhelming the page.Problem
In night mode,
.text-highlightrendered with the same fully-opaque#f8ff00background defined for light mode. Against a dark background this produced an uncomfortably bright flash of color that hurt readability rather than aiding it.Changes
.text-highlightoverride inside the@include color-mode(night, true)block inscss/themes/night.scss, settingbackground-color: rgba(248, 255, 0, 0.35)andcolor: inherit.Risk & testing
Follows the existing pattern used throughout
scss/themes/night.scssfor night-mode overrides. The light-mode rule incustom.scssis untouched. CSS-only change with no JavaScript impact.