a11y: associate a visible-hidden label with the room-name input#538
Open
xpoes123 wants to merge 1 commit into
Open
a11y: associate a visible-hidden label with the room-name input#538xpoes123 wants to merge 1 commit into
xpoes123 wants to merge 1 commit into
Conversation
xpoes123
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The room-name input on the multiplayer lobby page had no programmatically associated label, so screen readers could not announce its purpose when the field received focus.
Problem
In
client/play/mp/index.html, the<input id="new-room-name">was accompanied only by adjacent prose ("Create/Join a Room:") with no<label for="new-room-name">association. Assistive technologies rely on thefor/idlink to identify an input's purpose.Changes
<label class="visually-hidden" for="new-room-name">Room name</label>immediately before the input inside the existing input-group.Risk & testing
Markup-only change; visual layout is unchanged.
visually-hiddenis the Bootstrap utility class already used elsewhere in the codebase for screen-reader-only text. No JavaScript or styles are affected.