security: escape answer field in geoword admin compare view#537
Open
xpoes123 wants to merge 1 commit into
Open
security: escape answer field in geoword admin compare view#537xpoes123 wants to merge 1 commit into
xpoes123 wants to merge 1 commit into
Conversation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
xpoes123
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The canonical answer field in the geoword comparison view was interpolated directly into an innerHTML template literal without escaping, allowing a crafted answer string to inject arbitrary HTML and execute JavaScript when an admin views the page (stored XSS).
Problem
In
client/admin/geoword/compare.jsat the answer display line,myBuzz.answerwas passed throughremoveParenthesesand then inserted raw into the template:The
escapeHTMLutility was already imported and applied consistently to every other user-supplied field in the same file (givenAnswer, etc.), but was missing here.Changes
escapeHTML(removeParentheses(myBuzz.answer)), using the utility already in scope.Risk & testing
Single-line change; no new imports or dependencies.
escapeHTMLplain-escapes text — it does not attempt to sanitize markup — which is the correct treatment for a plain-text answer field. Behavior is identical for answers containing no HTML special characters.semistandardandnode --checkpass.