security: rate-limit POST /api/report-question to 30 requests/hour per IP#534
Open
xpoes123 wants to merge 1 commit into
Open
security: rate-limit POST /api/report-question to 30 requests/hour per IP#534xpoes123 wants to merge 1 commit into
xpoes123 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
POST /api/report-questionhad no rate limiting, making it trivial to flood the database with spurious reports.Problem
routes/api/report-question.jsaccepted an unlimited number of POST requests per IP. An automated client could generate thousands of bogus reports at no cost, polluting the moderation queue and adding unbounded write load to the database.Changes
express-rate-limit(already a project dependency) toroutes/api/report-question.js.standardHeaders: trueandlegacyHeaders: false, matching the pattern already used inroutes/auth/index.js.Risk & testing
Rate limiting is applied at the router level before the handler, so legitimate users are unaffected at normal usage volumes. No new dependencies introduced.
semistandardandnode --checkpass.