security: add X-Content-Type-Options, X-Frame-Options, and Referrer-Policy headers#533
Open
xpoes123 wants to merge 1 commit into
Open
security: add X-Content-Type-Options, X-Frame-Options, and Referrer-Policy headers#533xpoes123 wants to merge 1 commit into
xpoes123 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No security response headers were set on any route. This adds a small middleware in
app.jsthat applies three baseline headers to every response.Problem
Without
X-Content-Type-Options, browsers may MIME-sniff response bodies and execute content as a different type than declared. WithoutX-Frame-Options, any external site can embed qbreader pages in an iframe (clickjacking). WithoutReferrer-Policy, the full URL — including any query parameters — leaks to third-party origins via theRefererheader.Changes
X-Content-Type-Options: nosniffX-Frame-Options: SAMEORIGINReferrer-Policy: strict-origin-when-cross-originRisk & testing
Configuration-only, no logic changes. CSP is intentionally omitted to avoid breaking existing inline scripts and styles; HSTS is omitted since HTTPS is already enforced by the existing
httpsEnforcementmiddleware. No new dependencies.semistandardandnode --checkpass.