fix: remove completed and expired votekick entries from votekickList#531
Open
xpoes123 wants to merge 1 commit into
Open
fix: remove completed and expired votekick entries from votekickList#531xpoes123 wants to merge 1 commit into
xpoes123 wants to merge 1 commit into
Conversation
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Completed and abandoned votekick entries were never removed from
votekickListinServerMultiplayerRoomMixin.js, causing two distinct problems: the list grew without bound in long-lived rooms (slow memory leak), and a successful or expired votekick permanently blocked any future votekick against the same user until the server restarted.Problem
votekickInitshort-circuits if an entry for the target already exists:Because entries were never pruned, a completed kick — or one that simply expired — would prevent any re-initiation for that user for the lifetime of the server process. In rooms with heavy moderation activity, the list also accumulated unboundedly.
Changes
this.createdAt = Date.now()to theVotekickconstructor (VoteKick.js) so entries carry a timestamp.votekickListon the successfulcheck()branch in bothvotekickInitandvotekickVote, so a re-initiation is possible if the user rejoins after being kicked.cleanupExpiredBansAndKicksmethod usingBAN_DURATIONas the TTL, consistent with how bans and kicks are already expired.Risk & testing
In-progress votes are never disrupted: entries are only removed on success or after the TTL window has passed. The
cleanupExpiredBansAndKickspruning is additive — the surrounding ban/kick cleanup is unchanged.semistandardandnode --checkpass.