fix: catch adjustQuery errors to prevent unhandled rejection crash#530
Open
xpoes123 wants to merge 1 commit into
Open
fix: catch adjustQuery errors to prevent unhandled rejection crash#530xpoes123 wants to merge 1 commit into
xpoes123 wants to merge 1 commit into
Conversation
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
adjustQueryinquizbowl/QuestionRoom.jsawaits database calls (getPacket,getRandomQuestions) but is invoked fire-and-forget from synchronous message handlers with noawaitor.catch. A transient DB error produces an unhandled promise rejection, which terminates the Node process on Node 15+.Problem
Every call site invokes
adjustQuerywithout catching its return value:If
getPacketorgetRandomQuestionsthrows — for instance during a brief MongoDB hiccup — the rejection escapesadjustQuerywith no handler. Node 15+ converts unhandled rejections to fatal crashes, taking down all active rooms.Changes
switchblock insideadjustQueryin atry/catch.console.error(including the room name) and returns early.this.query) are still updated before the fetch, so the nextgetNextQuestioncall will refetch correctly.Risk & testing
The happy path is unchanged. The change is conservative: it contains the failure at a single point rather than requiring a
.catchat every call site.semistandardandnode --checkpass.