a11y: add aria-current to active db-explorer pagination links#529
Open
xpoes123 wants to merge 1 commit into
Open
a11y: add aria-current to active db-explorer pagination links#529xpoes123 wants to merge 1 commit into
xpoes123 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The tossup and bonus pagination in
client/db/index.jsxwas inaccessible to screen readers: the active page had no semantic marker, so assistive technologies announced all page links identically with no way to distinguish the current one.Problem
In both the tossup and bonus pagination loops, the active page link was identified only by a CSS class:
Two issues:
aria-currentattribute — screen readers cannot identify the current page.isActive && 'active'evaluates to the booleanfalse(not an empty string) when inactive, injecting the literal text"false"into theclassNamestring.Changes
aria-current={isActive ? 'page' : undefined}to the active page<a>in both the tossup (line 421) and bonus (line 480) pagination loops.${isActive ? 'active' : ''}to eliminate the spurious"false"class name.Risk & testing
Two-line mechanical change per pagination component. The visual rendering is identical for sighted users; only the DOM attribute and class string differ.
semistandardandnode --checkpass.