fix: use Bootstrap CSS variables in dropdown-checklist for night mode#525
Open
xpoes123 wants to merge 1 commit into
Open
fix: use Bootstrap CSS variables in dropdown-checklist for night mode#525xpoes123 wants to merge 1 commit into
xpoes123 wants to merge 1 commit into
Conversation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
xpoes123
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces hardcoded light-mode colors in
scss/dropdown-checklist.scsswith Bootstrap CSS custom properties so the filter dropdown renders correctly in night mode.Problem
The
.checkbox-menustyles used literal hex values:background-color: #fff— renders as a bright white rectangle in dark modecolor: #333— near-black text that may clash with a dark backgroundbackground-color: #f5f5f5— same issueThese values were set unconditionally, so night mode had no way to override them.
Changes
#fffwithvar(--bs-body-bg).#333withvar(--bs-body-color).#f5f5f5hover background withvar(--bs-tertiary-bg).Risk & testing
Bootstrap's default light-mode values for these variables match the original hex literals, so there is no visual change in the default theme. Night mode behavior was verified to render correctly. No JavaScript is touched.