security: set httpOnly, secure, and sameSite on the session cookie#524
Open
xpoes123 wants to merge 1 commit into
Open
security: set httpOnly, secure, and sameSite on the session cookie#524xpoes123 wants to merge 1 commit into
xpoes123 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hardens the
cookie-sessionconfiguration, which previously set none of the standard cookie security flags.Problem
In
app.js, the session cookie declared onlyname,keys, andmaxAge:httpOnly— readable by client-side JavaScript (session theft via XSS)secure— can be transmitted over plain HTTP (MITM interception)sameSite— sent on cross-site requests (CSRF)Changes
httpOnly: trueandsameSite: 'lax'.secure: process.env.NODE_ENV === 'production', so cookies are HTTPS-only in production (the app already callsapp.enable('trust proxy'), so this works behind the platform proxy) while local HTTP development keeps working.Risk & testing
Configuration-only change, no application logic altered.
secureis gated to production so local dev over HTTP is unaffected.semistandardandnode --checkpass.