Repository navigation
Expose bounded sides for step diameter leaders (#2211) - #2225
Merged
Merged
Conversation
pzfreo
force-pushed
the
fix/2211-step-diameter-side
branch
from
October 7, 2026 01:19
a341f2e to
aa0ae96
Compare
pzfreo
force-pushed
the
fix/2211-step-diameter-side
branch
from
October 7, 2026 01:49
aa0ae96 to
abc8192
Compare
Owner
Author
|
Rebased onto green #2224 and updated the exact leader-adapter guard for the side/control adapter. The former sole shard failure now passes locally ( |
pzfreo
force-pushed
the
fix/2211-step-diameter-side
branch
from
October 7, 2026 03:51
abc8192 to
8c0de7b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
step.diameterside controls: above/below on X, left/right on Z, and four hemispheres on Y. Step length does not advertise a diameter-leader side.placement_unsatisfiablewith measurement evidence, not a silent side switch.Local checks
Stacked on #2224. #2211 remains open for remaining feature-callout sides and merge verification.