Skip to content

Expose bounded sides for step diameter leaders (#2211) - #2225

Merged
pzfreo merged 4 commits into
fix/2211-step-diameter-lanefrom
fix/2211-step-diameter-side
Oct 7, 2026
Merged

pzfreo merged 4 commits into
fix/2211-step-diameter-lanefrom
fix/2211-step-diameter-side

Conversation

@pzfreo

@pzfreo pzfreo commented Oct 7, 2026 •

Copy link
Copy Markdown
Owner

Summary

  • Offer exact step.diameter side controls: above/below on X, left/right on Z, and four hemispheres on Y. Step length does not advertise a diameter-leader side.
  • Constrain the shared measured leader solve to the requested side; a short side-only reach keeps the established Z-left corridor usable. No-override routing remains unchanged.
  • Report an infeasible side as placement_unsatisfiable with measurement evidence, not a silent side switch.
  • Preserve source-authored thread/knurl identity for controlled diameter leaders; verify both side and lane controls with visible and omitted PMI.
  • Preserve source-shape budgets through extracted compound-side validation and update the dimension-options contract.

Local checks

  • Focused X/Y/Z rendering, source-PMI identity, side refusal, lane regressions, and source-shape guards pass (14 focused tests after rebase).
  • Dimension-options and view-routing slice: 34 passes; the three newly supported option cases now pass.
  • Full mypy, Ruff, formatting, codespell and strict docs pass.

Stacked on #2224. #2211 remains open for remaining feature-callout sides and merge verification.

@pzfreo

pzfreo commented Oct 7, 2026

Copy link
Copy Markdown
Owner Author

Rebased onto green #2224 and updated the exact leader-adapter guard for the side/control adapter. The former sole shard failure now passes locally (test_late_joint_assignment_stays_scoped_to_the_post_drain_adapters); the new head is in CI. No placement code changed in this correction.

@pzfreo
pzfreo force-pushed the fix/2211-step-diameter-side branch from abc8192 to 8c0de7b Compare October 7, 2026 03:51
@pzfreo
pzfreo added this pull request to stack #2229 October 7, 2026 03:52
@pzfreo
pzfreo merged commit 82e94cc into main Oct 7, 2026
19 of 29 checks passed
@pzfreo
pzfreo deleted the fix/2211-step-diameter-side branch October 7, 2026 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant