Repository navigation
Expose bounded lanes for rotational OD dimensions (#2211) - #2223
Merged
Merged
Conversation
This was referenced Oct 7, 2026
pzfreo
force-pushed
the
fix/2211-od-lane
branch
from
October 7, 2026 03:51
edd7992 to
ba7050f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bottom of GitHub stack #2229, based on main (including #2217). An exact od.diameter layout override now moves the existing OD dimension through the shared whole-ink assignment on Z-, X-, and Y-axis turned parts. If the preferred exterior side cannot fit the measured ink on the page, it uses the equivalent opposite witness; if neither candidate is feasible, it reports the requested lane and blockers against the approved OD measurement. No-lane output keeps the existing renderer path.
Local checks: six focused/no-override coverage tests, 105 diameter/architecture regressions, source-shape guards, full mypy, Ruff, codespell, strict docs build, and 97% changed production-line coverage. This does not close #2211; step diameter lanes and remaining feature-callout sides still need work. Merge atomically with stack #2229 only when every required check is green.