Skip to content

Expose exact X/Y location lanes for declared holes and patterns (#2211) - #2221

Merged
pzfreo merged 4 commits into
fix/2211-height-lanefrom
fix/2211-location-lanes
Oct 7, 2026
Merged

pzfreo merged 4 commits into
fix/2211-height-lanefrom
fix/2211-location-lanes

Conversation

@pzfreo

@pzfreo pzfreo commented Oct 7, 2026 •

Copy link
Copy Markdown
Owner

Stacked on #2222 in GitHub stack #2229. Adds bounded, coordinate-free lane overrides for one Z-normal hole or pattern location component selected by axis and member. Compiler, renderer, generated replay, and report retain distinct X/Y intent; unavailable lanes produce location_ref_dropped evidence with blockers. Coincident ordinates only share ownership when their lane also matches. Existing no-lane placement remains unchanged.

Local checks: 79 location/source-shape tests, 23 override tests, report schema regressions, full mypy, Ruff, codespell, strict docs build. The combined rebased tip passes 85 focused/source-shape tests and static checks. Fresh CI and changed-line coverage on this PR are the merge gate; merge atomically with stack #2229 only when every required check is green.

@pzfreo
pzfreo force-pushed the fix/2211-location-lanes branch from 85a4952 to 94df344 Compare October 7, 2026 00:37
@pzfreo pzfreo changed the title Expose exact X/Y location lanes for declared holes (#2211) Expose exact X/Y location lanes for declared holes and patterns (#2211) Oct 7, 2026
@pzfreo

pzfreo commented Oct 7, 2026

Copy link
Copy Markdown
Owner Author

The prior CI coverage report found 63/76 changed source lines covered (82%). Added a focused unavailable-location-lane test that locally executes all six previously missing _locations.py lines (304–305, 314, 318–320) and asserts exact measurement identity plus blocker evidence. With unchanged source diff, that should raise the combined changed-line count to at least 69/76 (90.8%); the new CI run remains the authority. Focused test and Ruff pass locally.

Base automatically changed from fix/2211-editor-dimension-side to main October 7, 2026 02:50
@pzfreo
pzfreo force-pushed the fix/2211-location-lanes branch from 05dfad5 to 12b0e3a Compare October 7, 2026 03:51
@pzfreo
pzfreo changed the base branch from main to fix/2211-height-lane October 7, 2026 03:52
@pzfreo
pzfreo added this pull request to stack #2229 October 7, 2026 03:52
@pzfreo
pzfreo force-pushed the fix/2211-location-lanes branch from 12b0e3a to a380bb5 Compare October 7, 2026 03:57
@pzfreo
pzfreo merged commit 42db578 into main Oct 7, 2026
19 checks passed
@pzfreo
pzfreo deleted the fix/2211-location-lanes branch October 7, 2026 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant