Repository navigation
Expose declaration IDs and label boxes for editor picking (#2210) - #2215
Merged
Merged
Conversation
pzfreo
enabled auto-merge (squash)
October 6, 2026 23:22
pzfreo
disabled auto-merge
October 7, 2026 00:17
pzfreo
enabled auto-merge (squash)
October 7, 2026 00:19
Owner
Author
|
Iterative review found a substantive ownership bug: an anchored note with its own declaration ID could make an unrelated mark owned by the anchor feature appear ambiguous to declaration_id_of(). Fixed in 6e704d9 by matching the mark's actual declared owner, with a regression covering both the feature mark and the note mark. Local verification: 17 declaration/source-shape tests, Ruff, mypy, 96% changed-line coverage. Auto-merge is armed again for the corrected head; the obsolete pre-fix CI run was canceled. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2210. Adds read-only
Drawing.declaration_id_of(name)andDrawing.label_box(name); ambiguous or undeclared annotations returnNone, unknown names raiseKeyError. The declaration lookup uses built model identities and the existing annotation registry, including measurement provenance when a direct feature owner is absent. Verified against the emitted Specify spindle Sheet (hole, step, AP242 dimension, GD&T, datum and OD) and focused tests; ruff, mypy, source-shape guards and codespell pass.