Skip to content

Avoid duplicate overall and coaxial-location dimensions (#2206) - #2213

Merged
pzfreo merged 3 commits into
mainfrom
fix/2206-source-dimension-coverage
Oct 7, 2026
Merged

pzfreo merged 3 commits into
mainfrom
fix/2206-source-dimension-coverage

Conversation

@pzfreo

@pzfreo pzfreo commented Oct 6, 2026

Copy link
Copy Markdown
Owner

Fixes #2206. The compiler now withholds the bbox-derived overall height when a proved AP242 end-to-end dimension already owns that turned profile. A source bore-axis location may also cover a coaxial pattern-centre location when the central bore and physical witnesses prove equivalence; unrelated same-valued locations remain. Adds focused regression tests and checks both reported STEP files at the compiled-plan boundary. Local focused tests: 6 passed; ruff and mypy passed.

@pzfreo
pzfreo enabled auto-merge (squash) October 6, 2026 23:22
@pzfreo
pzfreo merged commit 978a0aa into main Oct 7, 2026
19 checks passed
@pzfreo
pzfreo deleted the fix/2206-source-dimension-coverage branch October 7, 2026 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Authored dimension does not cover the planner's matching overall length or plane-to-axis location (duplicates remain after #2198)

1 participant