Repository navigation
Place source PMI before generated pattern pitch - #2204
Merged
Merged
Conversation
added 6 commits
October 6, 2026 16:02
pzfreo
enabled auto-merge (squash)
October 6, 2026 22:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked after #2203; advances #2192. On AP242 imports, defer compiled hole/pocket/slot pattern pitch until source-owned linear PMI has used the shared corridor. Reuse the existing pitch placer afterward, so the grid pitch is retained when it fits and its normal named drop is reported when it does not. Non-imported and caller-declared drawings keep their current timing.\n\nThe Specify source-to-drawing regression asserts all three source-owned basic 40 locations and both compiled grid pitches on a fixed A1 1:1 diagnostic. The combined default automatic drawing with #2202/#2203 also places all three 40s, datum B, and both pitches without PMI/pitch drops. The optional section still yields.\n\nLocal: focused regression, pattern suite (30 passed), Ruff and complexity budget. Review and CI are required before retargeting/merging to main.