Skip to content

Avoid duplicate planned locations for authored bore axes - #2201

Merged
pzfreo merged 2 commits into
mainfrom
fix/authored-basic-location-precedence
Oct 6, 2026
Merged

pzfreo merged 2 commits into
mainfrom
fix/authored-basic-location-precedence

Conversation

@pzfreo

@pzfreo pzfreo commented Oct 6, 2026

Copy link
Copy Markdown
Owner

Summary

  • Match a planned hole X/Y location to its authored AP242 location when both witness the same physical bore axis, even if STEP measures at an interior Z station while recognition uses the mouth.
  • Require the other in-plane coordinate and bore depth to agree. Pattern centres, shallow overlapping bores and orthogonal locations remain distinct.
  • Add a regression for these ambiguous cases.

Closes #2198.

Evidence

  • On the Specify plate, compiler locations 35, 85 and bore 60 are now covered by their corresponding authored source IDs; the pattern-centre and pocket 60 entries remain separate semantic measurements.
  • Focused tests (including source-shape gates) and scripts/pr-check --static passed.

The #2192 no-room drops remain within the active goal and are not claimed fixed here.

@pzfreo
pzfreo merged commit 0aacc3d into main Oct 6, 2026
19 checks passed
@pzfreo
pzfreo deleted the fix/authored-basic-location-precedence branch October 6, 2026 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Authored basic hole locations drawn twice in the plan (35, 85, 60 on the Specify plate)

1 participant