Skip to content

Preserve AP242 theoretical dimensions as boxed basic ink - #2200

Merged
pzfreo merged 3 commits into
mainfrom
fix/ap242-basic-dimensions
Oct 6, 2026
Merged

pzfreo merged 3 commits into
mainfrom
fix/ap242-basic-dimensions

Conversation

@pzfreo

@pzfreo pzfreo commented Oct 6, 2026

Copy link
Copy Markdown
Owner

Summary

  • Preserve AP242 theoretical/basic dimension intent through PMI extraction, authored IR, and shared placement.
  • Render supported basic dimensions with the existing boxed-dimension ink; report unsupported/conflicting cases instead of silently drawing them unboxed.
  • Add focused AP242 and finished-drawing regressions.

Closes #2199.

Verification

Review notes

  • Existing shared placement stages remain the only placement path; no raw coordinates were introduced.
  • Source matching prefers exact Part21 association and only falls back when matching display facts agree on basic status.

@pzfreo
pzfreo merged commit da987f8 into main Oct 6, 2026
19 checks passed
@pzfreo
pzfreo deleted the fix/ap242-basic-dimensions branch October 6, 2026 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Authored basic (theoretically exact) dimensions are drawn without a box

1 participant