Repository navigation
Measure parallel-plane AP242 spans along their normals - #2186
Merged
Merged
Conversation
pzfreo
force-pushed
the
fix/2184-plane-reference-span
branch
3 times, most recently
from
October 4, 2026 18:16
4cea6d5 to
717ef23
Compare
pzfreo
enabled auto-merge (squash)
October 4, 2026 18:18
pzfreo
force-pushed
the
fix/2184-plane-reference-span
branch
from
October 4, 2026 18:52
717ef23 to
34a6c44
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
Use the actual planar support normals to establish the measurement axis for an AP242 linear or thickness dimension between two parallel face groups that are each internally coplanar. The face centres may differ sideways when the projected witness coordinate is supported by both face groups. Only their separation along the proven principal normal is compared with the source nominal. A Y-axis dimension is restricted to side or plan when only one view has supported witnesses. Direct XCAF groups and exact Part21 support groups use the same rule. Other support types retain the existing station validation.
Closes #2184. Plane-to-axis support remains #2162.
Evidence
tests/test_issue_1209_linear_pmi_witnesses.py: 18 passed.tests/test_pmi.py: 89 passed, 1 deselected.tests/test_pmi_part21.py: 101 passed.tests/test_nominal_step_pmi.py: 5 passed.git diff --checkpassed. The one broad-run source-shape failure came from a complexity baseline tightened during that run; it passed after the baseline update.The reporter's private AP242 file was unavailable, so that exact file was not replayed. The regression exercises both extraction paths with real planar topology. This PR addresses principal parallel planes; it does not implement the distinct plane-to-axis relationship in #2162.
Architectural fit
An independent fresh-agent review found two witness/view cases; both were fixed and rereviewed with no remaining findings. The first final-head CI run reported 89% changed-line coverage; two additional Y-view outcome tests and an unreachable-branch cleanup raised final-head changed-line coverage to 93% (86 changed lines, 6 missing). The reviewer also checked that delta. No ADR invariant or boundary changes; no ADR text changed.