Skip to content

Keep candidate carriers when protected gutters push views off-page - #1879

Merged
pzfreo merged 1 commit into
mainfrom
fix/ftc09-candidate-parity
Sep 27, 2026
Merged

pzfreo merged 1 commit into
mainfrom
fix/ftc09-candidate-parity

Conversation

@pzfreo

@pzfreo pzfreo commented Sep 27, 2026

Copy link
Copy Markdown
Owner

Refs #1813, #1831, #1832.

FTC09's exact-source three-platform cost run 36330010666 completed both workers but candidate-preview lost PMI source geometric_tolerance:0:1:4:32 and the 190.5 envelope width. The saved trace showed protected candidate gutters put the plan 6 mm farther off the fixed A2/1:1 sheet, while the bounded plan-below strip could not take the width.

This changes only the pre-render profile choice: if a protected-gutter profile puts a principal view off-page and the existing iso-growth profile reduces per-view overflow without worsening another, select iso-growth before rendering. It does not build or inspect a finished baseline, change the caller's page/scale, or claim safety admission. The choice records both profiles and overflow evidence; chooser version is 5.

Verification:

  • Focused chooser/product tests: 14 passed; ruff and diff check passed.
  • One bounded changed-source FTC09 candidate-only worker at b8108cd: offline parity against the saved Linux baseline artifact from run 36330010666 passed (no missing/added annotations, equal coverage/drops, no introduced blockers); quality is a tie and the SVG SHA-256 equals the saved baseline's 313f6312192b93d17a1a026592e1cfb77cd373f7390590ca0cd2a37c86236712. No baseline worker or passed fixed15 case was rerun.
  • Saved fixed15 Linux artifact from run 36198994169: all ten protected-gutter candidate choices had on-page principal view geometry, so this branch condition would not alter those recorded choices.

Limitations: FTC09 still fails independent view/annotation page containment and other shared completeness checks. The saved-baseline comparison is cross-source diagnostic evidence, not an exact-head rollout gate; PR #1878 must collect one new exact-head supported-platform FTC09 run after this fix lands.

@pzfreo
pzfreo enabled auto-merge (squash) September 27, 2026 16:06
@pzfreo
pzfreo merged commit 627bf17 into main Sep 27, 2026
19 checks passed
@pzfreo
pzfreo deleted the fix/ftc09-candidate-parity branch September 27, 2026 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant