Repository navigation
Keep candidate carriers when protected gutters push views off-page - #1879
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #1813, #1831, #1832.
FTC09's exact-source three-platform cost run 36330010666 completed both workers but candidate-preview lost PMI source geometric_tolerance:0:1:4:32 and the 190.5 envelope width. The saved trace showed protected candidate gutters put the plan 6 mm farther off the fixed A2/1:1 sheet, while the bounded plan-below strip could not take the width.
This changes only the pre-render profile choice: if a protected-gutter profile puts a principal view off-page and the existing iso-growth profile reduces per-view overflow without worsening another, select iso-growth before rendering. It does not build or inspect a finished baseline, change the caller's page/scale, or claim safety admission. The choice records both profiles and overflow evidence; chooser version is 5.
Verification:
Limitations: FTC09 still fails independent view/annotation page containment and other shared completeness checks. The saved-baseline comparison is cross-source diagnostic evidence, not an exact-head rollout gate; PR #1878 must collect one new exact-head supported-platform FTC09 run after this fix lands.