Skip to content

ci: opt-in PR cost evidence for issue 1813 - #1860

Merged
pzfreo merged 1 commit into
issue-1813-fixed15-visual-ledgerfrom
issue-1813-pr-cost-trigger
Sep 26, 2026
Merged

pzfreo merged 1 commit into
issue-1813-fixed15-visual-ledgerfrom
issue-1813-pr-cost-trigger

Conversation

@pzfreo

@pzfreo pzfreo commented Sep 25, 2026

Copy link
Copy Markdown
Owner

Child of #1813 and cost gate #1832; follows #1859 in stack #1816.

The three-platform fixed15 cost workflow was manual-only and could not run while its file existed solely on the PR stack: workflow_dispatch requires the workflow on the default branch. This adds an opt-in pull_request:labeled path gated by the annotation-layout-cost label. Normal PR pushes and synchronizations do not run the expensive matrix. The labeled run checks out the exact PR source head and records that SHA separately from GitHub's synthetic PR merge/event SHA, so cost evidence is attributable to the code actually measured.

The existing manual path remains. The workflow still uses one CAD worker at a time and uploads its report, per-case JSON, SVGs, and machine/source provenance. This PR does not alter candidate selection, safety admission, defaults, or fallback. The fixed15 cost result is only one gate; large/user parts and interim fallback-frequency evidence remain outstanding.

Review: inspected the two-file diff for event scoping, permissions, exact-head checkout, and source attribution; git diff --check passed. scripts/pr-check --static passed (format, typing, docs). The labeled event itself will be exercised once on this PR; no prior CAD corpus was rerun locally.

@pzfreo pzfreo added the annotation-layout-cost Run opt-in three-platform annotation layout cost matrix label Sep 25, 2026
@pzfreo
pzfreo added this pull request to stack #1816 September 25, 2026 23:00
@pzfreo

pzfreo commented Sep 25, 2026

Copy link
Copy Markdown
Owner Author

Iterative review at exact head 0ba17cc: accepted this workflow slice. The two-file diff is scoped to an opt-in pull_request:labeled trigger and source attribution. Ordinary push/synchronize events cannot start the expensive matrix; contents permission remains read-only; checkout uses the exact PR head rather than the synthetic merge SHA. scripts/pr-check --static passed, all standard PR checks are green, and the trigger plus checkout/dependency/provenance steps succeeded on Linux, macOS, and Windows in run 36198994169. The CAD measurement steps are still live and are a separate cost-evidence gate, not a claimed pass or a reason to rerun earlier tests. No default/safety/fallback behavior changes here.

@pzfreo
pzfreo merged commit 482ad73 into main Sep 26, 2026
21 checks passed
@pzfreo
pzfreo deleted the issue-1813-pr-cost-trigger branch September 26, 2026 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

annotation-layout-cost Run opt-in three-platform annotation layout cost matrix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant