You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Code health: make compat shims warn and stop the suite importing through them #1936
Part of the code-health epic. Evidence pinned to main @ 71b8c94.
Problem
The version is 0.4.36.dev0, and these compatibility surfaces are still in the package:
score.py and recognition/__init__.py: "temporary" re-exports of quiddity, removal planned for 0.6.0.
make_drawing.py and annotate.py: annotate.py re-exports the private names _auto_annotate, _wrap_rows and _detect_step_repeat.
23 compatibility properties on Drawing (drawing.py:1291).
Two legacy export() call shapes (drawing.py:5850).
Four DeprecationWarning/SoftDeprecation sites in sheet.py.
None of the four shim modules emits a DeprecationWarning, so downstream users get no notice before the 0.6.0 removal. 12 of our own test files still import through draftwright.make_drawing or draftwright.annotate.
Proposal
Emit a DeprecationWarning from the four shim modules on import (or on attribute access), naming the replacement and the removal version.
Move our own tests onto the canonical imports, leaving one test per shim that asserts the warning.
Make a list of the Drawing compat properties with a removal version for each.
Activity
Warn on compatibility shims and migrate tests (#1936)
Detect package-level compatibility imports in suite guard (#1936)
Use actual annotation owners in shim migration tests (#1936)
Name every annotate shim replacement (#1936)
Warn on compatibility shims and migrate tests (#1936)
Detect package-level compatibility imports in suite guard (#1936)
Use actual annotation owners in shim migration tests (#1936)
Name every annotate shim replacement (#1936)
Pin honest grid pitch outcome in legacy slot fixture (#1936)
Refresh stale hole test expectations under shim migration (#1936)
Warn on compatibility shims and migrate tests (#1936)
Detect package-level compatibility imports in suite guard (#1936)
Use actual annotation owners in shim migration tests (#1936)
Name every annotate shim replacement (#1936)
Pin honest grid pitch outcome in legacy slot fixture (#1936)
Refresh stale hole test expectations under shim migration (#1936)
Warn on compatibility shims and migrate suite imports (#1936) (#1954)