You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Code health: introduce BuildOptions to collapse the 51-parameter build signature copied across six front doors #1927
So one new build option means editing about six signatures, their docstrings, and the forwarding between them. This is also where script/CLI parity bugs come from, because a parameter can be forwarded in one front door and missed in another.
Proposal
Add a frozen BuildOptions dataclass at the _core rank or below. It owns defaults and validation.
Internally, pass only BuildOptions.
Keep the public keyword signatures (they are the API), but have them build the dataclass once.
sheet_emit should serialise from BuildOptions and not keep its own list of parameters.
Acceptance
_build_drawing_once takes (source, options, …) and does not repeat the 47 shared parameters.
A test checks that every BuildOptions field is accepted by every public front door and round-trips through the emitted script. The test must fail if a field is added and not wired through.
Behaviour is unchanged: the golden corpus and script↔CLI parity tests stay green.
Architectural fit
ADR 1 (one engine, one front-door funnel). This needs no ADR change.
Completed in #1967 (merged 007ecad0). Frozen rank-1 BuildOptions now owns shared build defaults and validation; _build_drawing_once takes the options object, while public signatures and script emission stay stable. A parity guard classifies every option across front doors. The fresh final reviewer found no actionable issue. The full local run had the 19 failures and 3 errors already present on main, plus one new test-only compatibility-import failure that was corrected and passed in focused recheck; changed-line coverage was 98%. All 17 applicable CI jobs passed on the final commit, and 14 live drawing signatures and two emitted scripts matched baseline.
Activity
Share validated BuildOptions across build and script paths (#1927)
Preserve replay validation precedence (#1927)
Share validated BuildOptions across build and script paths (#1927) (#…
pzfreo commentedon Sep 28, 2026
Completed in #1967 (merged
007ecad0). Frozen rank-1BuildOptionsnow owns shared build defaults and validation;_build_drawing_oncetakes the options object, while public signatures and script emission stay stable. A parity guard classifies every option across front doors. The fresh final reviewer found no actionable issue. The full local run had the 19 failures and 3 errors already present on main, plus one new test-only compatibility-import failure that was corrected and passed in focused recheck; changed-line coverage was 98%. All 17 applicable CI jobs passed on the final commit, and 14 live drawing signatures and two emitted scripts matched baseline.