Repository navigation
Preserve non-UTF-8 bytes in simulator dialogues - #241
Merged
MatthieuDartiailh merged 1 commit intoSep 28, 2026
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #241 +/- ##
==========================================
+ Coverage 86.78% 87.92% +1.13%
==========================================
Files 19 20 +1
Lines 1052 1118 +66
Branches 114 116 +2
==========================================
+ Hits 913 983 +70
+ Misses 104 103 -1
+ Partials 35 32 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #227, reported by BT8298.
Dialogue bytes that are not UTF-8 can raise
UnicodeDecodeError. Preserve those bytes during dialogue matching and response formatting; skip text-only setters only if UTF-8 decoding fails.The suite passes.