Repository navigation
Close VXI-11 discovery sockets - #671
Merged
MatthieuDartiailh merged 2 commits intoOct 13, 2026
Merged
MatthieuDartiailh merged 2 commits into
MatthieuDartiailh merged 2 commits into
Conversation
Signed-off-by: CAOShurong <170531907+CAOShurong@users.noreply.github.com>
MatthieuDartiailh
approved these changes
Oct 13, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #671 +/- ##
==========================================
+ Coverage 54.74% 55.33% +0.59%
==========================================
Files 39 39
Lines 6518 6549 +31
Branches 649 652 +3
==========================================
+ Hits 3568 3624 +56
+ Misses 2854 2827 -27
- Partials 96 98 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
VXI-11 discovery creates a UDP port-mapper client for each interface but leaves their sockets to garbage collection. Calling
ResourceManager("@py").list_resources()on current main produces an unclosed-socketResourceWarning.Keep all created clients until a
finallycleanup, including clients whose broadcast fails, while preserving successful discovery results. The regression covers successful discovery and both send and receive errors.Related to #507. Its original asyncio traceback was not reproduced; this fixes the separate socket-lifecycle problem found through the same discovery entry point.
pre-commitwith no errorsCHANGESentryValidation: 309 passed, 160 skipped; strict Sphinx build and installed-wheel discovery checks passed. Physical instruments were not tested. No protocol-compliance changes.