Repository navigation
Preserve the default timeout when opening USB resources - #670
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #670 +/- ##
==========================================
+ Coverage 57.81% 60.84% +3.03%
==========================================
Files 39 39
Lines 6573 6584 +11
Branches 653 653
==========================================
+ Hits 3800 4006 +206
+ Misses 2661 2468 -193
+ Partials 112 110 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
@CAOShurong can you address the conflict ? |
# Conflicts: # CHANGES
|
Merged current main ( |
# Conflicts: # CHANGES
Signed-off-by: CAOShurong <170531907+CAOShurong@users.noreply.github.com>
|
One last rebase and we should be good. Thanks for all your contributions. |
Signed-off-by: CAOShurong <170531907+CAOShurong@users.noreply.github.com> # Conflicts: # .github/workflows/ci.yml # CHANGES
Opening a USB INSTR or USB RAW resource without an explicit timeout currently replaces the default 2000 ms timeout with an infinite timeout.
USBSession.after_parsing()reuses the last loop variable (VI_ATTR_RSRC_LOCK_STATE) when looking up the timeout default, so it passes the lock-state default of zero instead.Look up
VI_ATTR_TMO_VALUEdirectly. The regression tests useResourceManager("@py").open_resource()with a stub USB interface and check both the public VISA attribute and the timeout passed to the interface. They cover both resource classes, the default, an explicit finite timeout, and an explicit infinite timeout. The changelog and USB compliance notes are updated.Validation on Windows / Python 3.13:
4294967295instead of2000); the other six USB tests pass.TestSerial.test_serialfailure. Unmodified main has the same failure (358 passed, 1 skipped); it exercises the Windowsloop://routing covered by Preserve PySerial URLs when opening ASRL resources on Windows #664.Physical USB hardware was not used for these tests.