[Test] Port roi_pool (MPS) to stable ABI. - #9583
Draft
adabeyta wants to merge 1 commit into
Draft
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/9583
Note: Links to docs will display an error until the docs builds have been completed. ❌ 24 New Failures, 4 Pending, 1 Unclassified FailureAs of commit 1981680 with merge base 9f1d924 ( NEW FAILURES - The following jobs have failed:
UNCLASSIFIED FAILURE - DrCI could not classify the following job because the workflow did not run on the merge base. The failure may be pre-existing on trunk or introduced by this PR:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
adabeyta
force-pushed
the
adabeyta/roi-pool-mps-stable
branch
from
August 4, 2026 23:10
99f447f to
4fd4d29
Compare
NicolasHug
force-pushed
the
adabeyta/roi-pool-mps-stable
branch
from
August 5, 2026 14:09
4fd4d29 to
1981680
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports
roi_pool's MPS kernels to the stable ABI.Notes
torch_mps_set_arg_bytes.roi_pool_metal_shader.h. Once every MPS op migrates, the per-op headers can consolidate to a mps_stable_kernels.h and mps_kernels.h gets dropped.grad_output.device.type in ("cuda", "mps").