Skip to content

[Test] Port roi_pool (CUDA) to stable ABI. - #9582

Draft
adabeyta wants to merge 1 commit into
mainfrom
adabeyta/roi-pool-cuda-stable
Draft

[Test] Port roi_pool (CUDA) to stable ABI.#9582
adabeyta wants to merge 1 commit into
mainfrom
adabeyta/roi-pool-cuda-stable

Conversation

@adabeyta

@adabeyta adabeyta commented Aug 4, 2026

Copy link
Copy Markdown
Collaborator

Ports roi_pool's CUDA/ROCm kernels to the stable ABI.

Notes

  • Requires [Stable ABI] Move fastAtomicAdd to torch/headeronly. pytorch#191501, which lands torch::headeronly::fastAtomicAdd (the stable-ABI replacement for the backward's at::native::fastAtomicAdd).
  • Determinism layer change. The CUDA backward's at::globalContext().alertNotDeterministic call can't be made from a stable kernel, so it moves to the Python backward as torch._prims_common.alert_not_deterministic, gated to grad_output.device.type == "cuda".

Stable-ABI audit (torch-abi-audit)

Ran torch-abi-audit on a CUDA build. The counts don't move with this layer roi_pool's CUDA kernel references only unstable APIs already shared with the remaining legacy ops.

Package: torchvision
  Torch ABI:   UNSTABLE
  CPython ABI: n/a
  Bundled libs: 3
  -- bundled libs --
    [UNSTABLE] [not-abi3] _C.so            (stable_shim=0,  unstable=104)
    [STABLE  ] [not-abi3] _C_stable.so     (stable_shim=70, unstable=0)
    [STABLE  ] [not-abi3] image_stable.so  (stable_shim=76, unstable=0)

@pytorch-bot

pytorch-bot Bot commented Aug 4, 2026

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/9582

Note: Links to docs will display an error until the docs builds have been completed.

❌ 24 New Failures, 1 Pending, 1 Unclassified Failure

As of commit 1a7e398 with merge base 9f1d924 (image):

NEW FAILURES - The following jobs have failed:

UNCLASSIFIED FAILURE - DrCI could not classify the following job because the workflow did not run on the merge base. The failure may be pre-existing on trunk or introduced by this PR:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the cla signed label Aug 4, 2026
Base automatically changed from adabeyta/roi-pool-cpu-stable to main August 5, 2026 14:09
@NicolasHug
NicolasHug force-pushed the adabeyta/roi-pool-cuda-stable branch from 4fbcf57 to 1a7e398 Compare August 5, 2026 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant