Skip to content

[release/1.6] Fix OpenVINO bool operations and masked reads - #24493

Merged
JacobSzwejbka merged 1 commit into
release/1.6from
codex/release-1.6-clean-openvino-bool-masked-read-20261103
Nov 3, 2026
Merged

JacobSzwejbka merged 1 commit into
release/1.6from
codex/release-1.6-clean-openvino-bool-masked-read-20261103

Conversation

@JacobSzwejbka

Copy link
Copy Markdown
Contributor

Supersedes #24446 with a clean release pick from #24396.

Keeps unsupported bool-only min/max/clamp/sign operations on the CPU and populates tensor metadata for masked-read lowering. Includes their regression tests.

The bool test class is moved unchanged to test_bool_min_max.py so this PR can be based directly on release/1.6 without carrying the core OpenVINO commit.

Scope and landing order

Land after #24492 in the verified landing order.

This branch starts directly at release/1.6 commit dfb78b9ecd933a5fee33ebc94f69ed4b71cbb1e7. Its GitHub diff contains 4 files for this pick; it does not carry duplicate #24298 history or the excluded unmerged QNN work. Dependencies are documented here rather than embedded as other cherry-pick commits.

Verification

All changed Python files compile and pass Ruff F821 checks. All seven replacements merge cleanly in the documented sequence, including simulated squash merges. No QNN files are changed. The combined OpenVINO production code matches the previously reviewed final #24446 code; the bool test class is preserved unchanged.

Native CUDA, OpenVINO and portable C++ suites were not run locally on this macOS host; PR CI remains required before landing.

Prepared with OpenAI Codex.

Cherry-pick the bool partitioning and tensor-metadata fixes from #24396. Keep the matching bool tests in their own module and leave the core OpenVINO follow-ups in the preceding release pick.

Prepared with OpenAI Codex.
@pytorch-bot

pytorch-bot Bot commented Nov 3, 2026 •

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/24493

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures

As of commit c7fad44 with merge base 4db778e (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 3, 2026

@shoumikhin shoumikhin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please merge this after #24492: it uses module, which #24492 adds in preprocess.py.

@JacobSzwejbka
JacobSzwejbka merged commit 986c76f into release/1.6 Nov 3, 2026
209 of 218 checks passed
@JacobSzwejbka
JacobSzwejbka deleted the codex/release-1.6-clean-openvino-bool-masked-read-20261103 branch November 3, 2026 17:05
JacobSzwejbka added a commit that referenced this pull request Nov 3, 2026
Supersedes #24447 with a clean release pick from #24400.

Adds the portable antialiased bicubic kernel, edge-verifier exception,
registration/build wiring, regression tests and matching Arm
recipe/documentation updates from the source PR.

Changes exactly the 15 source PR paths.

## Scope and landing order

Land after #24493 in the
verified landing order.

This branch starts directly at release/1.6 commit
`dfb78b9ecd933a5fee33ebc94f69ed4b71cbb1e7`. Its GitHub diff contains 15
files for this pick; it does not carry duplicate #24298 history or the
excluded unmerged QNN work. Dependencies are documented here rather than
embedded as other cherry-pick commits.

## Verification

All changed Python files compile and pass Ruff F821 checks. All seven
replacements merge cleanly in the documented sequence, including
simulated squash merges. No QNN files are changed.

Native CUDA, OpenVINO and portable C++ suites were not run locally on
this macOS host; PR CI remains required before landing.

Prepared with OpenAI Codex.


cc @digantdesai @freddan80 @per @zingo @oscarandersson8218 @mansnils
@Sebastian-Larsson @robell @rascani

This branch was previously deployed

1 inactive deployment
cadence — c7fad446 Deployed Nov 3, 2026 by JacobSzwejbka via hifi-op-test / hifi4 #36189
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants