Skip to content

Pin the MCUXpresso SDK manifest revision in the NXP build test - #24479

Open
AxelNoun wants to merge 2 commits into
pytorch:mainfrom
AxelNoun:fix/nxp-pin-mcuxsdk-manifest
Open

AxelNoun wants to merge 2 commits into
pytorch:mainfrom
AxelNoun:fix/nxp-pin-mcuxsdk-manifest

Conversation

@AxelNoun

@AxelNoun AxelNoun commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

Summary

nxp-mcuxpresso-test is red on main and on every pull request, for a reason that has nothing to do with the code under test.

test_build_from_scratch.sh ran west init against mcuxsdk-manifests without a revision, so the job followed that repository's default branch — a moving target tracking the unreleased 26.12.00 SDK. That branch pins the fw_bin project to NXP/wifi_nb_fw@2553ab1d2097f0adb6e0846f054142c86045db3f, a commit the remote no longer serves. Because the project is declared with clone-depth: 1, west fetches that exact SHA and has no fallback:

fatal: remote error: upload-pack: not our ref 2553ab1d2097f0adb6e0846f054142c86045db3f
ERROR: update failed for project fw_bin
FATAL ERROR: Command failed: Update failed

This pins the manifest to v26.09.00, the most recent tag whose fw_bin revision still resolves (ae66e11f). The v26.12.00-pvw1 tag carries the same dangling pin as the default branch, so it is not an option. MCUXSDK_MANIFEST_REV lets the revision be overridden, matching how ARM_TOOLCHAIN_URL is already handled in the same script.

Beyond unbreaking the job, pinning removes a standing dependency on an upstream branch that can change under us at any time.

What was checked

  • The dangling SHA is genuinely absent from NXP/wifi_nb_fw (GitHub returns 422 No commit found for SHA).
  • At v26.09.00, every SDK path this example's CMakeLists.txt consumes exists: eiq_examples/executorch_cifarnet/{main.cpp,RegisterKernels.cpp}, eiq_examples/common/timer.c, _boards/mimxrt700evk/eiq_examples/executorch_cifarnet/cm33_core0/{hardware_init.c,pin_mux.c,gcc/MIMXRT798Sxxxx_cm33_core0_flash.ld} and .../npu.
  • Between v26.09.00 and the default branch, mcuxsdk-middleware-executorch advances by exactly one commit, a documentation URL fix — so the pin gives up nothing on the ExecuTorch side.

What was not checked

The full ARM build was not reproduced locally, so that the example still links against the September SDK rests on the file-level checks above rather than on an actual build. CI on this PR is the real verification.

west init tracked the mcuxsdk-manifests default branch, so nxp-mcuxpresso-test
followed an unreleased SDK. That branch pins fw_bin to NXP/wifi_nb_fw@2553ab1d,
a commit the remote no longer serves, so west update_board aborts with
"upload-pack: not our ref" and the job fails on main and on every pull request.

Pin the manifest to v26.09.00, the most recent tag whose fw_bin revision still
resolves, overridable through MCUXSDK_MANIFEST_REV.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@pytorch-bot

pytorch-bot Bot commented Nov 3, 2026 •

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/24479

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

⚠️ 24 Awaiting Approval

As of commit 1814227 with merge base ec56cfa (image):

AWAITING APPROVAL - The following workflows need approval before CI can run:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 3, 2026
@github-actions

github-actions Bot commented Nov 3, 2026

Copy link
Copy Markdown

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant